-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ghc 9.8 upgrade #1460
Merged
Merged
Ghc 9.8 upgrade #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a community fork which may be more reliable/up-to-date anyway: https://learnyouahaskell.github.io.
JeffreyHuynh1
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any issues with the upgrade and the passing tests give me confidence that it's a safe change! Also looked over the release notes for the subsequent upgrades and they're pretty minimal changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is to upgrade us to be on GHC 9.8. There are a few reasons I think this is good:
Release Notes and 9.4 -> 9.6 migration guide.
Release Notes and 9.6 -> 9.8 migration guide.
Very few of the changes to GHC or boot libraries seem to affect us day to day. Things that will:
Alternative
instances forEither
(docs) which was easily handled because theSemigroup
instance forEither
behaves the right way.head
/tail
as proposed here. I've turned these off for our CI builds because we already check for these usinghlint
to do this in a more refined way. They will be on for developers, but as warnings.Acceptance criteria
Testing plan
Risks
I don't think there are any that can be addressed further than I have.
Metrics
References
ANE-1757
Checklist
docs/
.docs/README.ms
and gave consideration to how discoverable or not my documentation is.Changelog.md
. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top..fossa.yml
orfossa-deps.{json.yml}
, I updateddocs/references/files/*.schema.json
AND I have updated example files used byfossa init
command. You may also need to update these if you have added/removed new dependency type (e.g.pip
) or analysis target type (e.g.poetry
).docs/references/subcommands/<subcommand>.md
.